build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )
Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb ......................................................................
Patch Set 8:
(12 comments)
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 33: static int get_pstate_info(struct acpi_sw_pstate *pstate_values, struct acpi_xpss_sw_pstate *pstate_xpss_values, int *max_pstate, uint32_t *thread_count); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 244: static int get_pstate_info(struct acpi_sw_pstate *pstate_values, struct acpi_xpss_sw_pstate *pstate_xpss_values, int *max_pstate, uint32_t *thread_count) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 260: pstate_values[pstate_count].core_freq = get_pstate_core_freq(pstate_def); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 267: pstate_xpss_values[pstate_count].core_freq = (uint64_t) pstate_values[pstate_count].core_freq; line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 268: pstate_xpss_values[pstate_count].power = (uint64_t) pstate_values[pstate_count].power; line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 297: cstate_base_address = rdmsr(MSR_CSTATE_ADDRESS ).lo & MSR_CSTATE_ADDRESS_MASK; space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 315: cstate_addr.addrl = cstate_base_address +1; need consistent spacing around '+' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 335: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 336: pstate_count = get_pstate_info(pstate_values, pstate_xpss_values, &max_pstate, &threads_per_core); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 354: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 356: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45340/8/src/soc/amd/picasso/acpi.c@... PS8, Line 360: acpigen_write_PSD_package(cpu / threads_per_core, threads_per_core, HW_ALL); line over 96 characters