Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant ......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/37dc48ce_6c2631f9 PS10, Line 143: bridge->power_on
but it seems that the callback `bridge_ps8640_post_power_on` isn't required, can we switch assert to […]
I agree we should use `if` instead of `assert` since the patch should be verified before submitting. But I think we can just check `bridge` in this patch(for Starme variants) and leave assertion as it is in this patch.
Let's review the assert usage in the MIPI patch.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/dccaef7d_6a4bdbf3 PS11, Line 128: Static_assert(CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1, : "Exactly one of KINGLER and KRABBY must be set");
should we keep this - adding BOARD_GOOGLE_STARMIE_COMMON ?
Yi-Ping left the comment here. https://review.coreboot.org/c/coreboot/+/74048/9/src/mainboard/google/corsol...