Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55198 )
Change subject: [RFC,WIP] cpu/x86/lapic: Evaluate x2apic_mode just once
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/55198/comment/42b5bfd9_7cdec61f
PS12, Line 84: return x2apic_mode_enabled;
I think it makes sense to return false when `is_x2apic_mode()` is called before `enable_lapic()` has been called.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff4f5dc50999f977eaf9b32e7caebf098a3600fe
Gerrit-Change-Number: 55198
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 10:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment