Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31999 )
Change subject: soc/intel/common: Move support to log XHCI wake events ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31999/3/src/soc/intel/common/block/xhci/elog... File src/soc/intel/common/block/xhci/elog.c:
https://review.coreboot.org/#/c/31999/3/src/soc/intel/common/block/xhci/elog... PS3, Line 72: event
The source parameter to elog_add_event_wake is a u8
Done
https://review.coreboot.org/#/c/31999/3/src/soc/intel/common/block/xhci/elog... PS3, Line 74: uint8_t i;
The instance parameter to elog_add_event_wake() is a u32, I don't think this needs to be a u8.
Done. Thanks for catching them.