Attention is currently required from: Rob Barnes, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58705 )
Change subject: mb/google/guybrush: Define ACPI Power Resources for FPMCU
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58705/comment/37e714c0_e8532a48
PS4, Line 18: TEST
Only other test I think we need is to update the FPMCU FW. I thought the script unbound the driver, so not sure if the _OFF method will be called in that case.
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58705/comment/6c3a3e03_9467d2d9
PS4, Line 178: enable_delay_ms
We are actually configuring the enable GPIO to TX state '0' (i.e. disable) in ramstage. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52322eaecf6961ff9a196ca9ab2d58b7d4599d4f
Gerrit-Change-Number: 58705
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Craig Hesling
hesling@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Nov 2021 17:53:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment