Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29971 )
Change subject: qcs405: Clear bss for bootblock ......................................................................
Patch Set 13:
I was considering whether this should be hidden behind a kconfig flag, but I doubt that there will be bootblocks on arm64 with "huge" bss sections where it would matter. Julius, any opinion on that?
This is not needed. The bootblock is linked treated as a binary image where all the .bss is already included in the .data section, so it does not need to be initialized separately. I assume this patch was just cherry-picked from an early version of Cheza code before I told them the same thing -- if you follow the Makefile stuff from more recent Cheza patches, this shouldn't be necessary anymore.
As a separate problem to the immediate question of how to get Mistral to work, I'd be open to discussing whether we want to generally switch to self-cleared bootblock .bss (and not including it in the BootROM-loaded binary) on all Arm devices. There are some advantages to that although I don't think it's a big problem in general (especially if you're using COMPRESS_BOOTBLOCK). However, if we want to do that it needs to be done in a way that works on and benefits all platforms.