Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31239 )
Change subject: src/mb: Remove include <commonlib/loglevel.h>
......................................................................
Patch Set 3:
Patch Set 3:
Depending on indirect includes is not wanted, and they should be added explicitly. So I think, we should keep it like that.
Does anything use the loglevels without using the console though?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief61106eb78d0de743c920f358937c51658c228a
Gerrit-Change-Number: 31239
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:29:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment