Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43861 )
Change subject: mb/*/*/devicetree.cb: Normalize disabled PIRQ values
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43861/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43861/1//COMMIT_MSG@10
PS1, Line 10: bits are meaningless and might as well be zero for consistency.
The values are also written to PCI devices. I don't think it's wrong, […]
Any specific suggestions on how to reword it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78980b9ea5e878a6200df0f6c18c5e7d06a7950a
Gerrit-Change-Number: 43861
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Sat, 25 Jul 2020 11:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment