Attention is currently required from: Felix Singer, Sean Rhodes, Michael Niewöhner, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60212 )
Change subject: mb/starlabs/labtop: Add enum for `power_profile`
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/starlabs/labtop/include/variants.h:
https://review.coreboot.org/c/coreboot/+/60212/comment/4fb94367_1661f654
PS1, Line 11: PP_PERFORMANCE = 2,
might be an idea to add a last entry without explicitly assigning a value to that and then just use […]
If I do this, then GCC will complain that `NUM_POWER_PROFILES` is not handled in the switch statements using a value of this enum type as control variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47a453ea12d164d26908a9944a89a481757e753c
Gerrit-Change-Number: 60212
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 18 Dec 2021 13:18:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment
