24 Jul
2020
24 Jul
'20
4:42 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )
Change subject: mb/google/volteer: Add gpio-keys ACPI node for PENH ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... PS5, Line 74: EDGE_BOTH
Aaron, that's a good idea. […]
Looks like I was out of date, gpiolib seems to use this field directly to setup the irqflags:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/driv...
--
To view, visit https://review.coreboot.org/c/coreboot/+/43764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida3217a5b156320856ce3302c2623eba2230f28d
Gerrit-Change-Number: 43764
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Levin levinale@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Alex Levin levinale@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Jul 2020 16:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Comment-In-Reply-To: Alex Levin levinale@google.com
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment