John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41759 )
Change subject: soc/intel/tigerlake: Add Type-C IOM base address and size macro
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41759/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41759/1//COMMIT_MSG@7
PS1, Line 7: Configure
Currently, only macros are added, so nothing is configured yet?
Updated as "Add Type-C IOM base address and size macro".
https://review.coreboot.org/c/coreboot/+/41759/1//COMMIT_MSG@12
PS1, Line 12:
Please add what section in what datasheet this is described in.
Updated the description by adding EDS(#575681) and IOM base address determination.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d88ba318087f7acacd1ee84609c9db5b65f907
Gerrit-Change-Number: 41759
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 May 2020 19:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment