Attention is currently required from: Dmitry Ponamorev, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )
Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8
......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:
https://review.coreboot.org/c/coreboot/+/57194/comment/5411e0ee_ae22d92e
PS19, Line 31: default "1.0.12"
Done
I meant there is a visible choice in menuconfig named LOCALVERSION. Setting that will be reflected in SMBIOs strings. See patchset #21.
File src/mainboard/teleplatforms/D4E4S16P8/romstage.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/b2472b9f_df30434d
PS20, Line 437: {SOUTH_GROUP0_CTBTRIGINOUT,
Except for this, this is all copy-paste from intel/harcuvar. Some like eMMC below seems wrong.
Dmitry, would you go thru the list against schematics?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188
Gerrit-Change-Number: 57194
Gerrit-PatchSet: 21
Gerrit-Owner: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: King Sumo
kingsumos@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: King Sumo
kingsumos@gmail.com
Gerrit-Comment-Date: Tue, 14 Dec 2021 04:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dmitry Ponamorev
dponamorev@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment