[coreboot-gerrit] Change in coreboot[master]: mb/kontron/mal10: Add COMe-mAL10 minimal support

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )

Change subject: mb/kontron/mal10: Add COMe-mAL10 minimal support
......................................................................

Patch Set 20: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... 
File src/mainboard/kontron/mal10/gpio.h:

https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... 
PS20, Line 46: _PAD_CFG_STRUCT(GPIO_15,
             : 		PAD_FUNC(GPIO) | PAD_RESET(DEEP) |
             : 		PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE |
             : 		PAD_BUF(NO_DISABLE),
             : 		PAD_PULL(DN_20K) | PAD_IOSSTATE(TxLASTRxE) | PAD_IOSTERM(SAME)),
Any reason for not adding these obviously needed and missing macros in src/soc/intel/common/block/include/intelblocks/gpio_defs.h.
Then you can simply use the needed macros here which would make your file more readable.