Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33193 )
Change subject: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM ......................................................................
Patch Set 1:
(2 comments)
Can’t this be checked by the code, if the UPD is provided?
https://review.coreboot.org/#/c/33193/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33193/1//COMMIT_MSG@9 PS1, Line 9: This patch provides an additional option to skip : HECI function disabling using SMM mode for WHL and CML platform, : where FSP has dedicated UPD to make HECI function disable. Please format that paragraph to use the whole text width.
https://review.coreboot.org/#/c/33193/1/src/soc/intel/common/block/smm/Kconf... File src/soc/intel/common/block/smm/Kconfig:
https://review.coreboot.org/#/c/33193/1/src/soc/intel/common/block/smm/Kconf... PS1, Line 32: This Kconfig will help to skip HECI function disable using : SMM mode. User to only select this option if FSP provide : dedicated UPD to perform HECI function disable. Skip HECI function disable using SMM. Only select htis option if FSP provides a dedicated UPD to perform HECI function disable.