Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42441 )
Change subject: mb/google/hatch: Set Reset Power Cycle Duration for hatch platforms
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@21
PS3, Line 21: Test=Verified on hatch
Along with these CL and overriding reset_delay in the FAFT Puff XML, I observe test "platform_ServoP […]
Done
https://review.coreboot.org/c/coreboot/+/42441/10/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42441/10/src/mainboard/google/hatch...
PS10, Line 147: #NOTE: Duration programmed in the below register should never be smaller than the
: #stretch duration programmed in the following registers -
Space after # please
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I368c6716a92e06903a872f9e87ae0698eab95bdd
Gerrit-Change-Number: 42441
Gerrit-PatchSet: 12
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 25 Jun 2020 12:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment