Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Dehui Sun has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
Change subject: soc/mediatek/mt8196: Add booker driver ......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85362/comment/49323077_229f964f?usp... : PS10, Line 10: e(
space
Okay, This will be modified in the next release.
https://review.coreboot.org/c/coreboot/+/85362/comment/07faf1b7_2c76a56b?usp... : PS10, Line 16: set bit[3]
it is needed to clear bit 3 (disable_cmo_prop) in por_sbsx_cfg_ctl register of each SBSX node in ord […]
Okay, This will be modified in the next release.
File src/soc/mediatek/mt8196/booker.c:
https://review.coreboot.org/c/coreboot/+/85362/comment/916f2f95_f4bd157d?usp... : PS10, Line 11: OFF_REG_POR_SBSX_CFG_CTL
POR_SBSX_CFG_CTL_OFFSET
Okay, This will be modified in the next release.
https://review.coreboot.org/c/coreboot/+/85362/comment/7bdc6805_8842f8f4?usp... : PS10, Line 25: 64p
I think it is a 32-bit register ?
NO. The register por_sbsx_cfg_ctl is 64bits width by checking CI-700 TRM.