Meng-Huan Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48113 )
Change subject: libpayload: Provide API to expose MMU memery ranges for ARM64
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include...
File payloads/libpayload/include/arm64/arch/mmu.h:
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include...
PS4, Line 202: mmu_get_ranges
I agree with Yu-Ping, these are really only the _used_ (occupied) memory ranges, not all valid DRAM. […]
Oops. You are right. This structure only store occupied memory, not mapped. I was confused by other MMU functions. Then, I agree it is appropriate to have "used" in function name.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39b24aefc9dbe530169b272e839d0e1e7c697742
Gerrit-Change-Number: 48113
Gerrit-PatchSet: 6
Gerrit-Owner: Meng-Huan Yu
menghuan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 07:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Meng-Huan Yu
menghuan@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment
