Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Elyes Haouas has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83859?usp=email )
Change subject: mb/google/brya/variants: Enable pch_hda_sdi_enable for trulo baseboard
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83859/comment/9de0cab8_e8943fb4?usp... :
PS2, Line 44: register "pch_hda_sdi_enable[0]" = "1"
: register "pch_hda_sdi_enable[1]" = "1"
sorry I forgot the "", […]
hmm, I think , it should be ok without ""
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83859?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e0f43b8fffb5e583089769d2c7446b476ce5d5d
Gerrit-Change-Number: 83859
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 10 Aug 2024 12:29:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr