Attention is currently required from: Bora Guvendik, Furquan Shaikh, Paul Menzel, Sumeet R Pawnikar, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57462 )
Change subject: mb/intel/adlrvp: set power limits dynamically for thermal
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
are those board- or soc-specific? only had a very brief look at the code, but if those settings are soc-specific and not board-specific, i'd move that out of the mainboard code into the soc code in a follow-up patch to not need the table and code in every mainboard
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ba901fe7c978aad43b85a860c71b33bfbff2ff5
Gerrit-Change-Number: 57462
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 18:42:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment