Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34809 )
Change subject: arch/x86: Add postcar_frame_common_mtrrs()
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34809/7/src/arch/x86/include/arch/c...
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/34809/7/src/arch/x86/include/arch/c...
PS7, Line 305: int skip_common_mtrr;
I do think we could have just done with opposite logic -- add_common_mtrr and then hidden postcar_frame_common_mtrrs() within the compilation unit and called it from run_postcar_phase(). However, that reduces the API surface area a bit and no callers care but the ones you are touching here. Let's see how this plays out, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1f8b7682035e654231f6133a42909a36e3e15a1
Gerrit-Change-Number: 34809
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Aug 2019 04:40:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment