26 Feb
2019
26 Feb
'19
2:52 p.m.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31619 )
Change subject: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/acpi/gpio_o... File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/acpi/gpio_o... PS2, Line 115: , Arg1
This is storing the intermediate result, right? Seems unnecessary. […]
makes sense, i will just use the mask to set/unset the bit
--
To view, visit https://review.coreboot.org/c/coreboot/+/31619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c40d79debb61b0c4e96e485b410d446b77d9cf6
Gerrit-Change-Number: 31619
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Feb 2019 14:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment