Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43883 )
Change subject: mb/google/glados: Relocate devicetree FSP settings ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... File src/mainboard/google/glados/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 40: ProbelessTrace
that's for tracehub, iirc. […]
I'll check this option later. It doesn't directly control a device.
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 41: DspEnable
could be moved to hd audio, too
I couldn't figure out if there's a dedicated device that corresponds to this option. It depends on HDA being enabled, but also needs to be used by something on I2C
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 43: SsicPortEnable
move to usb?
Does it correspond to a specific PCI device?
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 44: Cio2Enable
devtree missing
Which PCI device does this correspond to?
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 46: SkipExtGfxScan
move to gfx dev?
It's `1` everywhere. I think I can flip the default in a separate change.