[coreboot-gerrit] Change in coreboot[master]: nb/intel/pineview: Use new mchbar{8,16,32}_and_or()

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )

Change subject: nb/intel/pineview: Use new mchbar{8,16,32}_and_or()
......................................................................

Patch Set 2:

(1 comment)

I like the introduction of the common MCHBAR accessor functions.
Should we make them take a mask of bits to clear like the new
pnp `unset_and_set` functions (CB:42134)?

NB. Please stop pretending that anything is fixed, if the change
merely silences wrong warnings.

https://review.coreboot.org/c/coreboot/+/45517/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45517/2//COMMIT_MSG@7 
PS2, Line 7: nb/intel/pineview: Use new mchbar{8,16,32}_and_or()
           : 
           : This fix the overflow error we have with MCHBARx_AND_OR macros:
These two statements seem not related. Switching from macros to
functions only changes where the numbers are reduced (where the
overflow is noticed) but shouldn't get rid of the warnings (unless
the compiler is confused). The spurious warnings are then hidden
by manual casts, AFAICS.