Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver
......................................................................
Patch Set 18:
(2 comments)
File src/soc/mediatek/common/include/soc/mt6363.h:
https://review.coreboot.org/c/coreboot/+/85127/comment/3e451734_9463c46b?usp... :
PS17, Line 111: void mt6363_write_field(u32 reg, u32 val, u32 mask, u32 shift);
Move after write8.
Done
File src/soc/mediatek/common/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/e0ee2a0b_263b4223?usp... :
PS17, Line 38: reg_val
data
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85127?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf493b802522deba575d98c2ed69a93e94ce3d4e
Gerrit-Change-Number: 85127
Gerrit-PatchSet: 18
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 05 Dec 2024 07:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com