Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31998 )
Change subject: mb/google/hatch: Add SX9310 SAR0 sensor ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/Kconfig@7 PS1, Line 7: DRIVERS_I2C_SX9310
nit: Arrange this in alphabetical order i.e. […]
Ack
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31998/1/src/mainboard/google/hatch/variants/... PS1, Line 240: register "reg_prox_ctrl0" = "0x10"
Are the values known good/usable?
I don't really know :) I got them from src/mainboard/google/poppy/variants/nocturne/devicetree.cb . I'm happy to delete them or modify them if you think that's better.