Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@4 PS4, Line 4: Peichao Li
Above it says *Wang* instead of *Li*.
Done
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@13 PS4, Line 13: peichao.wang
Please use *Peichao Wang*.
Done
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
Add a blank line between lines 1 and 2
Done
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... PS4, Line 12: register "slow_ppt_limit" = "6000" #mw : register "fast_ppt_limit" = "9000" #mw : register "slow_ppt_time_constant" = "5" #second : register "stapm_time_constant" = "2500" #second : register "sustained_power_limit" = "4800" #mw
Please add a space after the comment characters, and use SI notations: mW.
Done