Attention is currently required from: Nick Vaccaro. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55340 )
Change subject: mb/google/volteer/var/chronicler: add chronicler memory configuration and gpio and devicetree settings ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/mainboard/google/volteer/variants/chronicler/gpio.c:
https://review.coreboot.org/c/coreboot/+/55340/comment/ff37c935_c70707f9 PS2, Line 28: DEEP
This should be "PLTRST", and this GPIO setting also needs to be added to the early_gpio_table below.
done
File src/mainboard/google/volteer/variants/chronicler/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/55340/comment/f1ac6059_496f4244 PS2, Line 1: H5ANAG6NCMR-XNC
This will not take affect until gen_part_id is run. […]
I had run below cmd to gen dram_id.generated.txt and Makefile.inc go run ./util/spd_tools/ddr4/gen_part_id.go src/soc/intel/tigerlake/spd src/mainboard/google/volteer/variants/chronicler/memory/ src/mainboard/google/volteer/variants/chronicler/memory/mem_parts_used.tx
File src/mainboard/google/volteer/variants/chronicler/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55340/comment/528ddf9d_fc2248d9 PS2, Line 34: 1
.early_init = CONFIG(MAINBOARD_HAS_SPI_TPM_CR50),
done