Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 31:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/c1917fe3_68c15bd0 PS31, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/ba51d6c0_52b349d2 PS31, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/1da8b957_6b35e80b PS31, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/61c625ab_dff079e0 PS31, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/09dd94ba_1c6b4445 PS31, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/efccb5fe_42abe868 PS31, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/860176d7_586e0d85 PS31, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/1388cadc_583330de PS31, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/b46fd2cd_51e951ed PS31, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/c577186b_7335e08a PS31, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/d2e5d0b1_07aa1b56 PS31, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/b6636078_d764ca5c PS31, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/920c573e_69d3f692 PS31, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/e78579ef_a3fd8c75 PS31, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/d65fbb20_d171d447 PS31, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/0d1e2769_55e7203e PS31, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/456b240e_18e21753 PS31, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/8f0feb03_f3a25e53 PS31, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/b6442a82_5711dffc PS31, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/13eca38f_028940c8 PS31, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/1d51cfdb_15589e83 PS31, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/46f4c9ff_e06b579e PS31, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/be39ba0d_b3c7527b PS31, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/876b02b0_90fdbe50 PS31, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/061d1a21_f67df604 PS31, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117950): https://review.coreboot.org/c/coreboot/+/49767/comment/519cc757_25a6b232 PS31, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line