Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39234 )
Change subject: sc7180: clock: Add support to bump CPU levels ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39234/5/src/soc/qualcomm/sc7180/clo... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39234/5/src/soc/qualcomm/sc7180/clo... PS5, Line 332: BIOS_INFO nit: BIOS_DEBUG is probably enough here
https://review.coreboot.org/c/coreboot/+/39234/5/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/39234/5/src/soc/qualcomm/sc7180/inc... PS5, Line 228: #define ETIMEDOUT 110 We don't use kernel errnos. Just return -1 from the function to signal error, that's enough in this case.