Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 )
Change subject: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41758/15/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41758/15/src/mainboard/intel/jasper... PS15, Line 374: CAM1 This is not the correct name for the power resource, it was "PRIC". However, if we're trying to make this compatible with windows, then you'll need to emit a path that doesn't start with "^", so the full path will be required, "_SB.PCI0.I2C5.CAM1.PRIC" I believe it would be. This is unfortunate, though 😞
If/When we get "alias" support in the devicetree, we can instead provide a reference to the other device and append "PRIC" to its ACPI path, instead of using hardcoded paths.
https://review.coreboot.org/c/coreboot/+/41758/15/src/mainboard/intel/jasper... PS15, Line 397: pci 05.0 on end # RP4 Sorry, I should have been more clear before.
It looks like the IPU0 device should be described in the following way:
device pci 05.0 on chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" register "acpi_name" = ""IPU0"" .... register "cio2_prt[1]" = "2" device generic 0 on end end end # IPU
If it isn't producing any output, then we'll need a minimal IPU PCI driver for JSL.