Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36089 )
Change subject: soc/mediatek/mt8183: Skip fast calibration in recovery mode ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem... PS2, Line 167: vboot_recovery_mode_enabled
This is already handled -- vboot_recovery_mode_enabled() and similar functions just always return 0 […]
Yes I know the APIs will return zero when not enabled, but was thinking that having these isolated should be more clear since the concept only lives per board, not SOC.
But if you also agree putting that there would make more sense, I can revert it back.
https://review.coreboot.org/c/coreboot/+/36089/5/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36089/5/src/soc/mediatek/mt8183/mem... PS5, Line 192: return;
nit: I got a bit confused about the code flow in all paths here, I think this would be easier to rea […]
Done