[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/zork: Implement touchscreen power sequencing

[Matt DeVillier (Code Review)]

Attention is currently required from: Jason Nien, Martin Roth.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69456 )

Change subject: mb/google/zork: Implement touchscreen power sequencing
......................................................................

mb/google/zork: Implement touchscreen power sequencing

As all variants have a touchscreen option, in baseboard tables set the
enable GPIO high and hold in reset during romstage, then release reset
in ramstage. This will allow the touchscreen to make use of the runtime
I2C detect feature (enabled in a subsequent commit) so that an ACPI
device entry is created only for the touchscreen actually present.

This mirrors the change to skyrim in CB:67778.

Change-Id: Ifdd75cd96e7b6880085a3f47214b92948a56aa2e
Signed-off-by: Matt DeVillier 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
2 files changed, 34 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/69456/1

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index f2c1a19..b182f41 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -64,7 +64,7 @@
    /* EC_AP_INT_ODL (Sensor Framesync) */
    PAD_GPI(GPIO_31, PULL_NONE),
    /* EN_PWR_TOUCHSCREEN */
-	PAD_GPO(GPIO_32, LOW),
+	PAD_GPO(GPIO_32, HIGH),
    /* GPIO_33 - GPIO_39: Not available */
    /* NVME_AUX_RESET_L */
    PAD_GPO(GPIO_40, HIGH),
@@ -148,8 +148,8 @@
    PAD_NF(GPIO_138, UART0_TXD, PULL_NONE),
    /* DEV_BEEP_BCLK */
    PAD_GPI(GPIO_139, PULL_NONE),
-	/* USI_RESET_L */
-	PAD_GPO(GPIO_140, LOW),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, HIGH),
    /* USB_HUB_RST_L */
    PAD_GPO(GPIO_141, HIGH),
    /* SD_AUX_RESET_L */
@@ -263,6 +263,11 @@
    	PAD_NF(GPIO_116, CLK_REQ2_L, PULL_NONE),
    	/* SD_AUX_RESET_L */
    	PAD_GPO(GPIO_142, HIGH),
+		/* Enable touchscreen, hold in reset */
+		/* EN_PWR_TOUCHSCREEN */
+		PAD_GPO(GPIO_32, HIGH),
+		/* TOUCHSCREEN_RESET_L */
+		PAD_GPO(GPIO_140, LOW),
    };

gpio_configure_pads(romstage_gpio_table, ARRAY_SIZE(romstage_gpio_table));
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 9864a93..a60eb18 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -108,7 +108,7 @@
    /* GPIO_89 - unused */
    PAD_NC(GPIO_89),
    /* EN_PWR_TOUCHSCREEN */
-	PAD_GPO(GPIO_90, LOW),
+	PAD_GPO(GPIO_90, HIGH),
    /* EN_SPKR */
    PAD_GPO(GPIO_91, LOW),
    /* CLK_REQ0_L - WIFI */
@@ -160,8 +160,8 @@
    PAD_NF(GPIO_138, UART0_TXD, PULL_NONE),
    /* DEV_BEEP_BCLK */
    PAD_GPI(GPIO_139, PULL_NONE),
-	/* USI_RESET_L */
-	PAD_GPO(GPIO_140, LOW),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, HIGH),
    /* UART1_RXD - FPMCU */
    PAD_NF(GPIO_141, UART1_RXD, PULL_NONE),
    /* SD_AUX_RESET_L */
@@ -271,6 +271,11 @@
    	PAD_NF(GPIO_132, CLK_REQ4_L, PULL_NONE),
    	/* SD_AUX_RESET_L */
    	PAD_GPO(GPIO_142, HIGH),
+		/* Enable touchscreen, hold in reset */
+		/* EN_PWR_TOUCHSCREEN */
+		PAD_GPO(GPIO_90, HIGH),
+		/* TOUCHSCREEN_RESET_L */
+		PAD_GPO(GPIO_140, LOW),
    };

gpio_configure_pads(romstage_gpio_table, ARRAY_SIZE(romstage_gpio_table));