1 Oct
2021
1 Oct
'21
8 p.m.
Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58064 )
Change subject: soc/intel/common/../cse: Helper function to check CSE device `devfn` status ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/58064/comment/131ef561_5d1198ea PS3, Line 587: printk(BIOS_WARNING, "HECI: No CSE device\n");
need one suggestion: […]
Yeah that makes sense to me to add slot/func to that message now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58064
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I208b07e89e3aa9d682837380809fbff01ea225b0
Gerrit-Change-Number: 58064
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 20:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment