Attention is currently required from: Kapil Porwal, Matt DeVillier, Nick Vaccaro, Sean Rhodes.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80486?usp=email )
Change subject: soc/intel/alderlake: Correctly set Usb4CmMode
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/80486/comment/7c9da284_beeaab30 :
PS4, Line 682: SOC_INTEL_ALDERLAKE_PCH_M
I thought `Usb4CmMode` existed for `SOC_INTEL_RAPTORLAKE` header alone. Isn't it appropriate to use the Raptor Lake over !SOC_INTEL_ALDERLAKE_PCH_M
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80486?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a99db165301ce08caf55aac0e33ca1994559d62
Gerrit-Change-Number: 80486
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 19 Feb 2024 05:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment