Attention is currently required from: Felix Held, Felix Singer, Nicholas Chin.
Hello Felix Held, Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83006?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+2 by Felix Held, Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: mb/dell/snb_ivb_latitude: Move E6430 USB config to devicetree ......................................................................
mb/dell/snb_ivb_latitude: Move E6430 USB config to devicetree
As of commit ee12634872 (nb/sandybridge,sb/bd82x6x: Configure USB from southbridge devicetree) and earlier commits, the USB port configuration should be located in the devicetree instead of the mainboard_usb_ports array, typically located in the boards early_init.c.
TEST=USB ports still function; and the USBIRx, USBPDO, USBOCM1, and USBOCM2 RCBA registers in the inteltool dump did not change between an E6430 build before and after the sb/intel/bd82x6x that moved the usb config to the devicetree.
Change-Id: Ia5aa03a5894a8ef29e863470925a223f52e0ab70 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/mainboard/dell/snb_ivb_latitude/variants/e6430/early_init.c M src/mainboard/dell/snb_ivb_latitude/variants/e6430/overridetree.cb 2 files changed, 16 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83006/2