Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Saurabh Mishra.
Nico Huber has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
Although I hit this issue due to different change, it can be replicated like:
What change?
Ping.
Test case1: Uisng $(if ,-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null) Result: Failure UPDATE-FIT Microcode E: Couldn't find microcode blob.
That's a different error. And also, we should try to reproduce the issue with the upstream coreboot main branch, without changes.
Patchset:
PS5: I'm still struggling to understand why Ubuntu behaves differently for you and me. Is there anything special about your installation maybe? Any extra package repositories? Any virtualization, a special container, WSL or anything like that?
If we can't figure this out, we can't report the bug upstream.
PS5:
Hi, Updated the patch to invoke another shell process.
Hmmm, I think now I understand where we misunderstood each other. What I meant is that with `:` make already invokes another shell, only to execute the `:`. Already one shell too many for my taste.
Now with `(:)` make will invoke a shell that executes this which will result in a second shell that eventually executes `:`.