[coreboot-gerrit] Change in coreboot[master]: SMM: Validate more user-provided pointers

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41086 )

Change subject: SMM: Validate more user-provided pointers
......................................................................

Patch Set 17:

(3 comments)

https://review.coreboot.org/c/coreboot/+/41086/17/src/mainboard/lenovo/t60/s... 
File src/mainboard/lenovo/t60/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41086/17/src/mainboard/lenovo/t60/s... 
PS17, Line 27: *(bar+LVTMA_BL_MOD_LEVEL)
This should really be using read8/write8 functions

https://review.coreboot.org/c/coreboot/+/41086/17/src/soc/intel/common/block... 
File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41086/17/src/soc/intel/common/block... 
PS17, Line 7: #include <commonlib/region.h>
I don't see any new calls to any region or rdev functions...

https://review.coreboot.org/c/coreboot/+/41086/17/src/southbridge/intel/bd82... 
File src/southbridge/intel/bd82x6x/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41086/17/src/southbridge/intel/bd82... 
PS17, Line 107: if (!smm_points_to_smram((void *)(uintptr_t)xhci_bar,
              : 		    0x4F0 + sizeof(uint32_t))) {
              : 			/* FIXME: This looks broken */
              : 			if ((xhci_bar + 0x4C0) & 1)
              : 				pch_iobp_update(0xEC000082, ~0UL, (3 << 2));
              : 			if ((xhci_bar + 0x4D0) & 1)
              : 				pch_iobp_update(0xEC000182, ~0UL, (3 << 2));
              : 			if ((xhci_bar + 0x4E0) & 1)
              : 				pch_iobp_update(0xEC000282, ~0UL, (3 << 2));
              : 			if ((xhci_bar + 0x4F0) & 1)
              : 				pch_iobp_update(0xEC000382, ~0UL, (3 << 2));
              : 		}
> Would prefer if this just return'ed instead of conditionally executing these. […]

I'd just drop this, it's broken