Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31860 )
Change subject: mb/google/octopus: Create Bloog variant ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/include/variant/gpio.h:
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 4: * Copyright 2018 Google LLC Furquan has already mentioned in one of the other files. Copyright year 2019 instead of 2018 where the copyright marking is added.
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 43: I believe the gSPI config for TPM communication can be added. I am not sure if you are waiting to tune it before adding here.
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 45: device pci 16.0 off end # - I2C 0 It seems PEN is not present. If so, can you please the concerned GPIOs as NC. Here are the GPIOs for your reference: GPIO_50, GPIO_51, GPIO_52, GPIO_53, GPIO_138, GPIO_139, GPIO_140, GPIO_144, GPIO_145.
Same about LTE GPIOs.