Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 )
Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62330/comment/f5296d8e_0cc4b72f
PS10, Line 213: rp6_wwan
Oh wait, don't we want […]
hum... pcie_rp6 is the parent device, while wwan is the companion device, which creates 'PXSX' device. There is always parent device with a pcie generic, but not necessary have other device attaching to the same root port. The idea is to point to the device whichever create the device object, if there is one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 11 Mar 2022 00:17:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment