Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34572 )
Change subject: soc/nvidia/tegra124: Assert divisor is non-zero
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34572/1/src/soc/nvidia/tegra124/clo...
File src/soc/nvidia/tegra124/clock.c:
https://review.coreboot.org/c/coreboot/+/34572/1/src/soc/nvidia/tegra124/clo...
PS1, Line 380: assert(plld.m != 0);
Why only m and not n? Seems pretty much the same situation in both cases here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34572
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60f49b8eed47a3de86713304bde7a4d3f3d935dd
Gerrit-Change-Number: 34572
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:22:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment