Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: Treewide: Add '-Wduplicated-branches' warning option ......................................................................
Patch Set 20:
(2 comments)
Please, put the fixes in separate commits, as some of your fixes introduced errors.
Angel, the warning found some valid errors.
``` CC ramstage/northbridge/intel/sandybridge/gma.o src/northbridge/intel/sandybridge/gma.c: In function 'gma_pm_init_pre_vbios': src/northbridge/intel/sandybridge/gma.c:473:5: error: this condition has identical branches [-Werror=duplicated-branches] if ((bridge_silicon_revision() & BASE_REV_MASK) == BASE_REV_IVB) { ^ ```
``` /* 11a: Enable Render Standby (RC6) */ if ((bridge_silicon_revision() & BASE_REV_MASK) == BASE_REV_IVB) { /* * IvyBridge should also support DeepRenderStandby. * * Unfortunately it does not work reliably on all SKUs so * disable it here and it can be enabled by the kernel. */ gtt_write(0xa090, 0x88040000); /* HW RC Control */ } else { gtt_write(0xa090, 0x88040000); /* HW RC Control */ } ```
Commit da83a5f1 (Fixes to enable RC6 on IvyBridge) [1].
[1]: https://review.coreboot.org/1268 I69d005ba56be8c7684a4ea1133a1d761f7c07acc
https://review.coreboot.org/c/coreboot/+/39561/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39561/1//COMMIT_MSG@7 PS1, Line 7: Treewide src
https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f... File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxIntegratedInfoTableTN.c:
https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f... PS20, Line 188: ((Channel == 0) ? D18F2x94_dct0_ADDRESS : D18F2x94_dct1_ADDRESS), What is the warning here? The code looks correct?