Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34369 )
Change subject: soc/amd/common: Avoid stage_cache if !HAVE_ACPI_RESUME ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34369/3/src/soc/amd/common/block/pi... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/c/coreboot/+/34369/3/src/soc/amd/common/block/pi... PS3, Line 314: How about instead, insert:
if (!CONFIG(HAVE_ACPI_RESUME) return Status;
https://review.coreboot.org/c/coreboot/+/34369/3/src/soc/amd/common/block/pi... PS3, Line 329: How about instead, insert:
if (!CONFIG(HAVE_ACPI_RESUME) return AGESA_UNSUPPORTED;
I'm not too worried about an error message, BTW. The call to this function gets removed from romstage when CONFIG_HAVE_ACPI_RESUME is not y.
https://review.coreboot.org/c/coreboot/+/34369/3/src/soc/amd/common/block/pi... PS3, Line 346: How about instead, insert:
if (!CONFIG(HAVE_ACPI_RESUME) return AGESA_UNSUPPORTED;
https://review.coreboot.org/c/coreboot/+/34369/3/src/soc/amd/common/block/pi... PS3, Line 365: same as above.