Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42830 )
Change subject: soc/amd/picasso: Add console & timestamp buffers to psp_verstage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver... PS3, Line 146: buffer_size = (uint32_t)((uintptr_t)_etimestamp - (uintptr_t)_vboot2_work);
After this path ctx will be NULL in Main() below.
Sorry, I think I'm missing something. Why would setting the buffer size change ctx to null? We're not touching ctx at all on this path. We only use it if we need to shrink the buffer in the other half of this if/else, right?
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver... PS3, Line 150: printk(BIOS_ERR, "Error: Buffer is larger than max buffer size.\n");
but this is still workbuf. Why change the error? Not a blocker.
Because the buffer may not be just the workbuf. It now might include the console and timestamp areas as well. I'll change it back if you want.