Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner, Rajesh Patil.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/google/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 95:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50581/comment/e8e584ea_5cc96821
PS71, Line 10: Load QUP FW in respective Serial Engines.
Paul, this is an unfinished platform port. […]
Understood. Then the commit message and/or TEST= line should make that clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 95
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Jan 2022 07:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment