Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Jérémy Compostella, Ravishankar Sarawadi, Saurabh Mishra, Wonkyu Kim.
Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/83785?usp=email )
Change subject: soc/intel/common: Add SoC QDF read function ......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/83785/comment/308abd62_2d0ba28c?usp... : PS4, Line 272: This function reads SoC QDF information. ```suggestion * This function reads SoC QDF information using PMC interface. ```
https://review.coreboot.org/c/coreboot/+/83785/comment/2a87322b_f2ccab66?usp... : PS4, Line 273: Panther Lake SoC. how can we ensure that no other platform is calling into this API ?
what is downside of calling into function over older platform ?
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/83785/comment/8d13b584_d282774e?usp... : PS4, Line 903: pmc_send_ipc_cmd is there any downside of sending this cmd for an older platform where I assume this cmd will fail for sure. Based on my previous understanding if one PMC IPC starts failing once then all consecutive cmd will fail for sure. I would like to ensure that we are only sending this cmd for the support platform alone. if that means, you need to introduce a newer Kconfig and select that from PTL onwards, I'm okay with it
``` config SOC_QDF_DYNAMIC_READ_PMC bool n depends on SOC_INTEL_COMMON_BLOCK_PMC help Enable this option if the platform supports reading SOC QDF data dynamically at runtime using the PMC IPC interface. ```