Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43494 )
Change subject: soc/intel/common/cpu: Update COS mask calculation for nem enhanced mode ......................................................................
Patch Set 3:
(4 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/43494/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43494/3//COMMIT_MSG@23 PS3, Line 23: mas maps
https://review.coreboot.org/c/coreboot/+/43494/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
PS3: Why bother to set the other masks (MASK_0 & MASK_1) if they're unused (PQR_ASSOC set to pick mask #2)
https://review.coreboot.org/c/coreboot/+/43494/3/src/soc/intel/common/block/... PS3, Line 425: 0x02 0x200000000
https://review.coreboot.org/c/coreboot/+/43494/3/src/soc/intel/common/block/... PS3, Line 445: 0x01 0x100000000