24 Mar
2022
24 Mar
'22
5:11 a.m.
Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: Add MAX98390 support for DOJO ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/cherry/Kconfig:
https://review.coreboot.org/c/coreboot/+/63083/comment/5aa88879_9c0c9be9 PS2, Line 66: BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO what about
if !BOARD_GOOGLE_DOJO
In fact I wonder if we can say
default y if !CHERRY_USE_RT1011 && !CHERRY_USE_MAX98380
--
To view, visit https://review.coreboot.org/c/coreboot/+/63083
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490
Gerrit-Change-Number: 63083
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 12:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment