Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60229 )
Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
Patchset:
PS3: Thanks!
File src/ec/starlabs/merlin/Kconfig:
https://review.coreboot.org/c/coreboot/+/60229/comment/8626fdbf_376724b1 PS3, Line 59: GPI GP*E*
If this somehow clashes with macro names, I'd just add a `STARLABS_` prefix or something.
File src/mainboard/starlabs/labtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/60229/comment/50098d06_f01fb620 PS3, Line 54: GPI GP*E*
File src/mainboard/starlabs/labtop/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/60229/comment/37337586_cbb292ba PS3, Line 3: #define EC_GPE_SCI CONFIG_EC_GPE_SCI Please also drop the define. It's currently only used in one place in your EC code:
src/ec/starlabs/merlin/acpi/ec.asl: Name (_GPE, EC_GPE_SCI)