Attention is currently required from: Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email )
Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84402/comment/a0d06880_37776a7a?usp... : PS2, Line 7: FSP1_1
The problem is the issue won't reproduce before the following patch so it is bit weird to mention […]
Technically this is not mandatory: "Test your patches before submitting them to gerrit. It’s also appreciated if you add a line to the commit message describing how the patch was tested. This prevents people from having to ask whether and how the patch was tested."
I tend to agree we should have one as much as possible, it just does not make sense here but since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this.