Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82133?usp=email )
Change subject: soc/intel/xeon_sp: Use pre-processor to define ASL handler names ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82133/comment/b161e3e5_66338385?usp... : PS7, Line 16: As to the parameter count of the ASL handler, which is limited to : 8 by ACPI specification. It is encouraged to use up the Arg0-7 : first. If the needed arguments exceed 8, the last Arg (Arg7) : could be passed as a package of more parameters, which could be : extracted into unused local variables in the ASL handler codes.
Does this have anything to do with the current change? I am confused by it.
This is just a informal comment on how to deal with the case of parameter inadequacy as follow up of previous code reviews. I removed it in this patch.
File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/82133/comment/83e7de22_74efb921?usp... : PS7, Line 131: ASL_HANDLER_PATH(AH_PCIE_OSC)
I am pretty sure this should work, as string literals can be concatenated at compile time: […]
Done
File src/soc/intel/xeon_sp/include/soc/asl_handler.h:
https://review.coreboot.org/c/coreboot/+/82133/comment/1f6bf1c1_97940e75?usp... : PS7, Line 6: #define TO_STR(name) #name
I think there's a macro for this somewhere in commonlib
Done